-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: High number of operations after update #1938
Comments
@julianocosta89 Thanks for reporting this. Unfortunately, the combination of using tracing for creating spans, and then bridging it to OTel via most likely, you can use Filters from |
hmmm 😢 @cijothomas is there any instrumentation library that is more connected to the OTel SIG? In that case we continue to showcase manual instrumentation with the server side, and instrumentation libraries with the client side. WDYT? |
Neither OTel Rust main repo (this) nor OTel Rust contrib repo has any instrumentation libraries! The ones used by demo project are maintained outside OTel orgs, but more importantly, they are instrumented using tokio-tracing, not OpenTelemetry. The right fix for that depends on #1571 itself. Examples in this repo only show manual instrumentation with OTel's own tracing API. (Although, it is possible that this will be considered wrong/deprecated, depending on the outcome of #1571) It is an unfortunate situation, and we are aware of it. @TommyCpp to share any additional recommendations. |
Is there any way @jtescher is one of the top contributors on the tokio-tracing and I see he is also part of the OTel group, maybe he could share his opinion here as well. Tokio would continue to be it's own thing, and Having OTel's semantic conventions and specifications in multiple languages is one of the greatest achievements and benefits of OTel. I'd love that for Rust as well. |
No. Pasting below the answer to that question by the maintainer of I don't believe so/unsure. To be frank, I don't see a future in which tracing would move under the CNCF: if it's ever to move from the tokio organization, it would be the rust-lang org, and that's a very big if. |
What happened?
Hello all 👋🏽
I was updating the OTel Demo to v0.23 (
tracing-opentelemetry
is still on0.23
) and I've noticed that I started getting a bunch of new spans from the Rust service.Before the update I had 3 operations:
oteldemo.ShippingService/ShipOrder
oteldemo.ShippingService/GetQuote
POST
After the update I got a total of 24 operations:
assign_connection_capacity
flush
FramedRead::decode_frame
FramedRead::poll_next
FramedWrite::buffer
FramedWrite::flush
hpack::decode
hpack::encode
poll
poll_ready
pop_frame
popped
Prioritize::queue_frame
read_preface
recv_stream_window_update
reserve_capacity
send_data
try_assign_capacity
try_reclaim_frame
updating connection flow
updating stream flow
All those new operations seem to be coming from
/usr/local/cargo/registry/src/index.crates.io-*/src/proto/streams/prioritize.rs
.Is that an expected behavior?
Can we suppress those spans?
Also the number of events per span increased significantly.
If you would like to take a look at the code, here is the PR: open-telemetry/opentelemetry-demo#1672, to run it execute the following commands from the root folder:
API Version
0.23
SDK Version
0.23
What Exporter(s) are you seeing the problem on?
OTLP
Relevant log output
No response
The text was updated successfully, but these errors were encountered: