Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate Logs from Traces for tracing-opentelemetry #1111

Open
2 tasks
hdost opened this issue Jun 15, 2023 · 0 comments
Open
2 tasks

Differentiate Logs from Traces for tracing-opentelemetry #1111

hdost opened this issue Jun 15, 2023 · 0 comments
Labels
A-log Area: Issues related to logs M-api M-sdk triage:todo Needs to be traiged.

Comments

@hdost
Copy link
Contributor

hdost commented Jun 15, 2023

Originally brought up in #1085
Could apply to other libraries as well.
Example use case: Datadog only parses LogRecords not SpanEvents.

  • Test methods for filtering
  • Benchmark methods.

Tracing crate already has ability to emit Logs Always (need to explore - https://docs.rs/tracing/latest/tracing/#emitting-log-records)

You shouldn't enable this feature for opentelemetry-rust. it's meant for libraries like hyper or tokio to smoothly transition to tracing in a minor semver release, allowing users to not immediately lose logging when then update their dependencies.

How do we user decide if this should go as span_event or log? [...] We need to investigate/explore this more. (there may be "Filter" that can be leverages Metadata)

Using dynamic_filter_fn is an option, but be sure to benchmark this since it might be a little too costly. We can always improve it on the tracing side of things though, especially since there is some low-hanging, performance-related fruit in tracing-subscriber that we've been meaning to improve. Y'all saying that it's a little too slow would sufficient for me to justify the positive impact of me working on fixing it.

Originally posted by @davidbarsky in #1085 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-log Area: Issues related to logs M-api M-sdk triage:todo Needs to be traiged.
Projects
None yet
Development

No branches or pull requests

2 participants