Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Propagate tracestate #73

Closed
mwear opened this issue Sep 10, 2019 · 3 comments
Closed

API: Propagate tracestate #73

mwear opened this issue Sep 10, 2019 · 3 comments
Assignees
Milestone

Comments

@mwear
Copy link
Member

mwear commented Sep 10, 2019

There was a PR to temporarily remove tracestate. It was opened due to confusion around what context belongs in tracestate, but ultimately never merged. The Context Propagation OTEP provides the necessary layers for the different types of context that users can interact with. It doesn't mention tracestate, and that is because tracestate is for context used by the tracer (SDK) implementation.

As discussed in a recent W3 Distributed Tracing Meeting OpenTelemetry should:

  • Propagate tracestate
  • Does not need to expose it via API
  • May expose it via SDK SPI if there is a use case
@fbogsany
Copy link
Contributor

The spec states:

SpanContext MUST be a final (sealed) class.

SpanContext is specified in the API, and currently contains the tracestate. How should this be hidden from the API but exposed (possibly) in the SDK and propagated?

@mwear
Copy link
Member Author

mwear commented Sep 11, 2019

Those words are from the meeting notes on 2019-09-10. I believe the intent is that trace state is for context needed for a tracing vendor and not for end users. So, it does need to be exposed on the SpanContext so that tracing vendors other SDK implementations can interact with it, but it should not be exposed to end users. This probably means that will be "protected" by a comment in the code, and not a language construct.

@fbogsany fbogsany added this to the Alpha milestone Sep 16, 2019
@fbogsany fbogsany self-assigned this Oct 30, 2019
@fbogsany fbogsany mentioned this issue Oct 30, 2019
1 task
@fbogsany
Copy link
Contributor

Fixed in #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants