Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enable_default_view option #2546

Closed
aabmass opened this issue Mar 24, 2022 · 0 comments · Fixed by #2547
Closed

Remove enable_default_view option #2546

aabmass opened this issue Mar 24, 2022 · 0 comments · Fixed by #2547
Assignees
@aabmass
Labels
metrics sdk Affects the SDK package.

Comments

@aabmass
Copy link
Member

aabmass commented Mar 24, 2022 •
edited
Loading

The enable_default_view behavior should be accomplished with views as described in open-telemetry/opentelemetry-specification#2417

SDK SHOULD enable the instrument using the default aggregation and temporality. Users can configure match-all Views using Drop aggregation to disable instruments by default.

E.g.

MeterProvider(
  views=[
    View(instrument_name="*", aggregation=DropAggregation()),
    View(instrument_name="<instrument1 to turn on>"),
    View(instrument_name="<instrument2 to turn on>"),
  ],
  ...
)
@aabmass aabmass added sdk Affects the SDK package. metrics labels Mar 24, 2022
@aabmass aabmass self-assigned this Mar 24, 2022
@aabmass aabmass mentioned this issue Mar 24, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aabmass aabmass

Labels
metrics sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove enable_default_view option from sdk MeterProvider aabmass/opentelemetry-python
1 participant
@aabmass