Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "record" for MeasureMetric #185

Closed
lzchen opened this issue Sep 27, 2019 · 3 comments
Closed

Implement "record" for MeasureMetric #185

lzchen opened this issue Sep 27, 2019 · 3 comments
Assignees
Labels
metrics sdk Affects the SDK package.
Milestone

Comments

@lzchen
Copy link
Contributor

lzchen commented Sep 27, 2019

Implementation of record for MeasureMetric in the SDK is not done.
There is still discussion about how we handle aggregation and configurations as well.

Part of [#155]
Follows [#160]

@lzchen lzchen added sdk Affects the SDK package. metrics labels Sep 27, 2019
@lzchen lzchen self-assigned this Sep 27, 2019
@c24t c24t added this to the Alpha v0.2 milestone Oct 11, 2019
@c24t c24t modified the milestones: Alpha v0.2, Alpha v0.3 Oct 31, 2019
@c24t c24t modified the milestones: Alpha v0.3, Alpha v0.4 Dec 5, 2019
@lzchen lzchen mentioned this issue Feb 13, 2020
7 tasks
@toumorokoshi toumorokoshi modified the milestones: Alpha v0.4, Beta Feb 27, 2020
@mauriciovasquezbernal
Copy link
Member

@lzchen https://github.com/open-telemetry/opentelemetry-python/pull/422/files#diff-ceb6c75131a7c968ee965da2a10fa5d2R51 implemented the MinMaxSumCount aggregator for Measure instruments, does it suffice or there is something missing for closing this issue?

@lzchen
Copy link
Contributor Author

lzchen commented Mar 3, 2020

I think this issue needs to be better scoped, it was created a long time ago when record was not implemented yet. Ideally for this to be "complete", all aggregations for measure should be finished but we can probably track those as separate issues. I'm fine with closing this one.

@lzchen
Copy link
Contributor Author

lzchen commented Mar 6, 2020

I think this issue can be closed. The default aggregation for measure is sufficient for the beta release, as the other aggregation types have not yet made it to the specs. I will create another issue for them once they are finalized in the specs.

@c24t @toumorokoshi

@c24t c24t closed this as completed Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics sdk Affects the SDK package.
Projects
None yet
Development

No branches or pull requests

4 participants