Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide safe defaults for span creation #18

Closed
c24t opened this issue Jun 20, 2019 · 1 comment
Closed

Provide safe defaults for span creation #18

c24t opened this issue Jun 20, 2019 · 1 comment
Labels
api Affects the API package.
Milestone
Tracing API

Comments

@c24t
Copy link
Member

c24t commented Jun 20, 2019

From #11 (review).

The tracing API should describe the default options for span creation with missing arguments. We can't do this unilaterally, see open-telemetry/opentelemetry-specification#141 to add this behavior to the spec.
@c24t c24t added the api Affects the API package. label Jun 20, 2019
@c24t c24t mentioned this issue Jun 20, 2019
Merged
@c24t c24t added this to the Tracing API milestone Jun 27, 2019
@c24t
Copy link
Member Author

c24t commented Sep 11, 2019

This was fixed in later changes to the tracer, we don't throw at all in the API now.

@c24t c24t closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Affects the API package.
Projects
None yet
Milestone
Tracing API
Development

No branches or pull requests
1 participant
@c24t