Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up tests around #1141 #1327

Closed
aabmass opened this issue Nov 2, 2020 · 0 comments · Fixed by #1671
Closed

Fix up tests around #1141 #1327

aabmass opened this issue Nov 2, 2020 · 0 comments · Fixed by #1671
Assignees
Labels
1.0.0rc2 release candidate 2 for tracing GA release:required-for-ga To be resolved before GA release

Comments

@aabmass
Copy link
Member

aabmass commented Nov 2, 2020

Changes from #1141 needs to be updated with some tests and maybe simplify the enum logic.

@aabmass aabmass self-assigned this Nov 2, 2020
@codeboten codeboten added the release:required-for-ga To be resolved before GA release label Nov 3, 2020
@codeboten codeboten added the 1.0.0rc2 release candidate 2 for tracing GA label Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0rc2 release candidate 2 for tracing GA release:required-for-ga To be resolved before GA release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants