Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'component' span attribute in instrumentations #300

Closed
mariojonke opened this issue Jan 27, 2021 · 0 comments · Fixed by #301
Closed

Remove 'component' span attribute in instrumentations #300

mariojonke opened this issue Jan 27, 2021 · 0 comments · Fixed by #301
Labels
bug Something isn't working

Comments

@mariojonke
Copy link
Contributor

The semantic convention for the component attritubte was removed in the specfication some time ago. See open-telemetry/opentelemetry-specification#336

There still exist some instrumentations (e.g. requests, aiohttp-client, everything using dbapi, ...) which add this attriubte.
Since it was removed in the specification instrumentations shouldn't set this attribute anymore.
@mariojonke mariojonke added the bug Something isn't working label Jan 27, 2021
@mariojonke mariojonke mentioned this issue Jan 27, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove 'component' span attribute in instrumentations mariojonke/opentelemetry-python-contrib
1 participant
@mariojonke