Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfluentKafkaInstrumentor's ProxiedConsumer does not support commit #1506

Closed
jeehun-pas opened this issue Dec 19, 2022 · 3 comments · Fixed by #1656
Closed

ConfluentKafkaInstrumentor's ProxiedConsumer does not support commit #1506

jeehun-pas opened this issue Dec 19, 2022 · 3 comments · Fixed by #1656
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jeehun-pas
Copy link

Describe your environment
Python 3.8
confluent-kafka[avro]==1.9.2
opentelemetry-instrumentation-confluent-kafka==0.35b0

Steps to reproduce
Call ProxiedConsumer.commit

What is the expected behavior?
Message is committed in Kafka cluster

What is the actual behavior?
Get an exception with message "Consumer closed"

Additional context
ProxiedConsumer is not an actual Consumer but using a private internal Consumer instance to do poll, consume, etc. It is missing an over-ridden version of ProxiedConsumer.commit which calls the private Consumer's commit.

@jeehun-pas jeehun-pas added the bug Something isn't working label Dec 19, 2022
@srikanthccv srikanthccv added the help wanted Extra attention is needed label Jan 1, 2023
@alolita
Copy link
Member

alolita commented Feb 6, 2023

@srikanthccv @lzchen can you please assign @mrajashree to this issue :-) She's working on a PR for this. Thanks!

@srikanthccv
Copy link
Member

Can you ask them to leave a comment? Username doesn't show up in the assignees dropdown otherwise.

@mrajashree
Copy link
Contributor

Thanks @alolita @srikanthccv for assigning me this issue (hope my username will now show up :-) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
4 participants