Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confluent-kafka-python produce headers could be dict or a list #1364

Closed
owenhaynes opened this issue Sep 30, 2022 · 5 comments · Fixed by #1655
Closed

confluent-kafka-python produce headers could be dict or a list #1364

owenhaynes opened this issue Sep 30, 2022 · 5 comments · Fixed by #1655
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed instrumentation

Comments

@owenhaynes
Copy link

Environment

Python 3.10
confluent-kafka[avro]==1.9.2
opentelemetry-instrumentation-confluent-kafka==0.34b0

Steps to reproduce
Pass a dict of headers to the producer

What is the expected behavior?
To not crash and handle using a list or a dict for the headers

What is the actual behavior?
crashes because of calling append on a dict of headers in KafkaContextSetter

Additional context
The docs say produce can take a dict or a list https://docs.confluent.io/platform/current/clients/confluent-kafka-python/html/index.html#confluent_kafka.Producer.produce

@owenhaynes owenhaynes added the bug Something isn't working label Sep 30, 2022
@srikanthccv srikanthccv added help wanted Extra attention is needed instrumentation labels Nov 5, 2022
@avzis
Copy link
Contributor

avzis commented Nov 29, 2022

hi, can you assign this to me?

@alolita
Copy link
Member

alolita commented Feb 6, 2023

@srikanthccv @lzchen can you please assign @mrajashree to this issue since there is no PR submission from the current assignee. Thanks!

@srikanthccv
Copy link
Member

@avzis let us know if you had already worked on this. I will assign @mrajashree otherwise. @mrajashree can you please a leave a comment here.

@avzis
Copy link
Contributor

avzis commented Feb 7, 2023

I'm not working on it, you can assign this to him

@mrajashree
Copy link
Contributor

thanks, glad to pick it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed instrumentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants