Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve metrics.proto by mentioning Resource Attributes and Scope #518

Closed
krisztianfekete opened this issue Dec 15, 2023 · 1 comment · Fixed by #519
Closed

Improve metrics.proto by mentioning Resource Attributes and Scope #518

krisztianfekete opened this issue Dec 15, 2023 · 1 comment · Fixed by #519

Comments

@krisztianfekete
Copy link
Contributor

krisztianfekete commented Dec 15, 2023

I think metrics.proto would benefit from listing Resource Attributes and Scope.

I am writing a blog on a related topic and would like to cross-reference the illustration in the proto file with the logging exporter.

I also added attribute to the key-value pairs.

I am thinking of something like this:

//     Metric
//  +--------------------+
//  |name                |
//  |resource attributes |
//  |description         |
//  |unit                |     +------------------------------------+
//  |data                |---> |Gauge, Sum, Histogram, Summary, ... |
//  +--------------------+     +------------------------------------+
//
//    Data [One of Gauge, Sum, Histogram, Summary, ...]
//  +-----------+
//  |...        |  // Metadata about the Data.
//  |points     |--+
//  +-----------+  |
//                 |      +---------------------------+
//                 |      |DataPoint 1                |
//                 |      |                           |
//                 |      |attribute                  |
//                 v      |+------+------+   +------+ |
//              +-----+   ||label |label |...|label | |
//              |  1  |-->||value1|value2|...|valueN| |
//              +-----+   |+------+------+   +------+ |
//              |  .  |   |+-----+                    |
//              |  .  |   ||value|                    |
//              |  .  |   |+-----+                    |
//              |  .  |   +---------------------------+
//              |  .  |                   .
//              |  .  |                   .
//              |  .  |                   .
//              |  .  |   +---------------------------+
//              |  .  |   |DataPoint M                |
//              |  .  |   |                           |
//              |  .  |   |attribute                  |
//              +-----+   |+------+------+   +------+ |
//              |  M  |-->||label |label |...|label | |
//              +-----+   ||value1|value2|...|valueN| |
//                        |+------+------+   +------+ |
//                        |+-----+                    |
//                        ||value|                    |
//                        |+-----+                    |
//                        +---------------------------+

Happy to open a PR as well. What do you think?

@tigrannajaryan
Copy link
Member

+1. I think it would be useful. Please use the same ASCII chart style for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants