Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish API Documentation #1378

Closed
svrnm opened this issue Sep 13, 2024 · 3 comments · Fixed by #1385
Closed

Publish API Documentation #1378

svrnm opened this issue Sep 13, 2024 · 3 comments · Fixed by #1385

Comments

@svrnm
Copy link
Member

svrnm commented Sep 13, 2024

While working on open-telemetry/opentelemetry.io#5190 I recognized that PHP has no API Docs published, similar to what other languages have. I did a quick test run locally and it seems that by using phpdocumentor a basic version can be created without a lot of effort

Is this something the SIG PHP is interested in? If so, I can provide a PR for generation of the docs.

What remains is to decide where the docs will be published. As you can see from the PR preview @ https://deploy-preview-5190--opentelemetry.netlify.app/api-docs/ different SIGs use different locations for that. I am not sure if there is a official or semi-offical place for php docs (like docs.rs for rust, https://hexdocs.pm for erlang, etc.), since this would be the best place for that. Otherwise, github pages is one option, or we can use netlify, which we also use to run opentelemetry.io

@brettmc
Copy link
Collaborator

brettmc commented Sep 17, 2024

Hi @svrnm I think it's a good idea to publish our API docs. I think in the PHP world it would be either readthedocs.io or github pages (it's not really documentation, so perhaps github pages is the better option?)

@svrnm
Copy link
Member Author

svrnm commented Sep 17, 2024

Hi @svrnm I think it's a good idea to publish our API docs. I think in the PHP world it would be either readthedocs.io or github pages (it's not really documentation, so perhaps github pages is the better option?)

Python, C++ are using readthedocs already, but they also make use of the additional features you get from rdt:

There is currently no CNCF owned (or otel community) owned rdt account from what I know, so both run independently and if you do not have an adblocker show ads. However this is something we can look into changing.

Node.JS is using github pages:

I ran a small experiment with the C++ docs (and I can do one for PHP as well), publishing the docs using netlify (which we use for opentelemetry.io and is paid by CNCF). It works very similar to github pages, so it can build from each commit or via a github action. The advantage is that we could use opentelemetry.io as part of the domain1.

Independent from the location I can prepare a PR for phpdocumentor to build the docs

Footnotes

  1. full transparency: I am a little bit excited about this opportunity/possibility to hose something like opentelemetry.io/api-docs/<language>, either with redirects or preferable without :-)

@brettmc
Copy link
Collaborator

brettmc commented Sep 18, 2024

publishing the docs using netlify

I'd be happy with that, and I see benefit in the API docs living under opentelemetry.io via netflify (if that's what you're suggesting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants