-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HorizontalPodAutoscaler code from v1 #943
Comments
What is the reasoning/use-case to migrate to v2beta2 or v2 on our end? Are we using any of the v2 features? from: https://kubernetes.io/docs/reference/using-api/deprecation-guide/
We cannot use v2 right now because we are supporting k8s 1.19.
|
The reason is to be able to add more features which will, among other things, permit us to change the scaledown time in order to run an e2e test (See #942) which does not run for an inordinate amount of time. v1 is fairly old. I was not able to find a release date, but I found references to v2beta2 from 2019. Jaeger Operator uses it, and the code that added that was written in January 2020. (See jaegertracing/jaeger-operator#856) |
from https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-26 We should migrate to
|
The current HPA code uses version v1 of the API. We should upgrade to v2 or v2beta2 depending on what is supported in the versions of kubernetes that we need to support.
The text was updated successfully, but these errors were encountered: