Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "enable-multi-instrumentation" flag by default #3090

Closed
iblancasa opened this issue Jul 1, 2024 · 6 comments · Fixed by #3302
Closed

Enable "enable-multi-instrumentation" flag by default #3090

iblancasa opened this issue Jul 1, 2024 · 6 comments · Fixed by #3302
Labels
area:auto-instrumentation Issues for auto-instrumentation enhancement New feature or request needs triage

Comments

@iblancasa
Copy link
Contributor

Component(s)

collector, auto-instrumentation

Is your feature request related to a problem? Please describe.

The features that are enabled by enable-multi-instrumentation have been there for a while and it might be a good time to enable them by default.

The only risk I can see is those user workloads using the instrumentation.opentelemetry.io/container-names would not be instrumented when they are restarted or recreated. We can implement a warning as part of the validation webhook + something as part of the upgrade routines in order to replace this annotation with the language-specific ones.

Describe the solution you'd like

.

Describe alternatives you've considered

No response

Additional context

No response

@iblancasa iblancasa added enhancement New feature or request needs triage labels Jul 1, 2024
@pavolloffay pavolloffay added the area:auto-instrumentation Issues for auto-instrumentation label Jul 3, 2024
@pavolloffay
Copy link
Member

@swiatekm @jaronoff97 any objections?

@swiatekm
Copy link
Contributor

swiatekm commented Jul 3, 2024

As far as I can see, this would be a breaking change, as the flag actually changes the behaviour, and different annotations must be used for multi-container instrumentation for the same language. Can we not avoid this breaking change, or at least allow the old annotations to work while the multi-instrumentation flag is enabled?

@pavolloffay
Copy link
Member

@iblancasa can we write an upgrade procedure to migrate already injected agents?

@iblancasa
Copy link
Contributor Author

. Can we not avoid this breaking change, or at least allow the old annotations to work while the multi-instrumentation flag is enabled?
@swiatekm With a migration procedure should be enough. But I agree that it would be better if we could make the instrumentation.opentelemetry.io/container-names annotation work when the flag is enabled. I'll try to send a PR to make it work when the annotation is there (I'm not sure if that would be considered a breaking change too).

@iblancasa can we write an upgrade procedure to migrate already injected agents?
@pavolloffay It is what I proposed in my first comment:

We can implement a warning as part of the validation webhook + something as part of the upgrade routines in order to replace this annotation with the language-specific ones.

I'll create a PR to address this.

@artem-nefedov
Copy link
Contributor

It seems that recent changes broke something, check #3213 (comment)

@iblancasa
Copy link
Contributor Author

It seems that recent changes broke something, check #3213 (comment)

#3307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:auto-instrumentation Issues for auto-instrumentation enhancement New feature or request needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants