-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new k8s distro #2835
Comments
At the moment the operator uses the core as a default distro https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol/manifest.yaml The proposal is to use https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-k8s/manifest.yaml This will be a breaking change for users. The k8s distribution does not have
exporters:
extensions:
processors:
|
So we do need to migrate after all. Thanks for being vigilant about this. In that case, do we go back to the original plan we hatched at KubeCon? That is, set the image to core while converting from v1alpha1 to v1beta1? |
Looking at that list, we actually use the |
I do think it may be worth updating the k8s distro to include the prom-remote-write exporter and prom exporter as both of those are things we know operator installations use |
I would agree about the p8s exporter. |
The k8s distribution rules state: Could we also do a cleverer conversion method, where we check which components the Collector is using, and keep core as the default image only if those components aren't present in the k8s distribution? @TylerHelmuth what do you think? It sounded like you gave some thought to doing this transition in the Helm Chart. |
To specifically address some of the differences:
So that leaves the prometheus exporters, which I do agree merit some consideration, but are probably not blockers for us. |
There is good history in the PR and issue, but it came down to favoring OTLP in an OpenTelemetry Community distribution over other export protocols - it is a slippery slope supporting other protocols, although an argument could be made for prometheus since it is Kubernetes if you'd like to raise it. @swiatekm-sumo the specific differences you addressed are all correct except that the |
I that case I would decouple shipping v1beta1 from the k8s distribution. |
Can we do that without a CRD version bump? It's going to a breaking change even if we do add the prometheus components. |
Is there a feature in the Operator that requires the Prometheus exporter? |
There isn't, but exporting metrics to Prometheus is something you'd commonly do in K8s, and ingest via OTLP is still experimental. |
Nots from the SIG meeting 2024/04/24 https://docs.google.com/document/d/1Unbs2qp_j5kp8FfL_lRH-ld7i5EOQpsq0I4djkOOSL4/edit
|
Component(s)
collector
Is your feature request related to a problem? Please describe.
We now have a kubernetes distro! 🎉 let's use that
open-telemetry/opentelemetry-collector-releases#507
Describe the solution you'd like
change all our core uses to the k8s distro
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: