Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1alpha2: make getConfigMapSHA a method of the new CRD #2591

Closed
frzifus opened this issue Feb 1, 2024 · 1 comment
Closed

v1alpha2: make getConfigMapSHA a method of the new CRD #2591

frzifus opened this issue Feb 1, 2024 · 1 comment
Assignees
@frzifus
Labels
area:collector Issues for deploying collector internal
Milestone
Collector v1beta1...

Comments

@frzifus
Copy link
Member

frzifus commented Feb 1, 2024

Component(s)

operator

Describe the issue you're reporting

#2532 (comment)
@frzifus frzifus mentioned this issue Feb 1, 2024
Merged
@frzifus frzifus self-assigned this Feb 1, 2024
@pavolloffay pavolloffay added the area:collector Issues for deploying collector label Mar 11, 2024
@pavolloffay pavolloffay added this to the v1beta1 CRD release milestone Mar 11, 2024
@pavolloffay
Copy link
Member

I would propose to close this ticket as won't do.

The only annotations.go are calculating hash from the collector config object

opentelemetry-operator/internal/manifests/manifestutils/annotations.go

Line 91 in 08b33a5

func getConfigMapSHA(config v1beta1.Config) (string, error) {
. Therefore it does not warrant to move the getConfigMapSHA to the public API package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frzifus frzifus

Labels
area:collector Issues for deploying collector internal
Projects
None yet
Milestone
Collector v1beta1 CRD release
Development

No branches or pull requests
2 participants
@pavolloffay @frzifus