Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers in OpAMP Bridge config #2410

Closed
jdcrouse opened this issue Dec 1, 2023 · 2 comments
Closed

Headers in OpAMP Bridge config #2410

jdcrouse opened this issue Dec 1, 2023 · 2 comments
Assignees
Labels
area:opamp Issues for the opamp resource enhancement New feature or request

Comments

@jdcrouse
Copy link
Contributor

jdcrouse commented Dec 1, 2023

Component(s)

opamp bridge

Is your feature request related to a problem? Please describe.

I want to connect an OpAMP bridge to a server that is deployed in an environment which requires an access token to be provided as a request header.

Describe the solution you'd like

The OpAMP client already has a field for headers— I want to amend the Bridge config to accept headers from a yaml config and propagate those through to the instantation of the OpAMP client within the bridge.

Describe alternatives you've considered

No response

Additional context

No response

@jdcrouse jdcrouse added enhancement New feature or request needs triage labels Dec 1, 2023
@jaronoff97 jaronoff97 added area:opamp Issues for the opamp resource and removed needs triage labels Dec 1, 2023
@jaronoff97
Copy link
Contributor

sounds good to me! I may recommend doing this in two PRs:

  1. make the change in cmd/operator-opamp-bridge to add the ability to set headers in the config
  2. make the change in the operator to allow the configuration of the headers in the CRD
    Beyond just easier reviewing, this would also assist our e2e runners when you add an e2e test for settings headers making it down to the configmap for the bridge.

@jaronoff97
Copy link
Contributor

closed by #2413 and #2414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:opamp Issues for the opamp resource enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants