Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New changes to Dockerfiles requires docker version >= 23.0 #2321

Closed
changexd opened this issue Nov 8, 2023 · 2 comments
Closed

New changes to Dockerfiles requires docker version >= 23.0 #2321

changexd opened this issue Nov 8, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@changexd
Copy link
Contributor

changexd commented Nov 8, 2023

Component(s)

No response

Describe the issue you're reporting

I found changes #2289 in the docker file that uses Automatic platform ARGs requires docker version >= v23.0

As I got stuck for a bit to find out that my docker version was older and not supporting this, is it possible to add this to the pre-requisites section in the CONTRIBUTION.md for future contributors also using the older version of docker.

@swiatekm
Copy link
Contributor

You mean for building the images, not running them, right? Yeah, we should make it explicit what version is required in CONTRIBUTING.md

@pavolloffay pavolloffay added help wanted Extra attention is needed and removed needs triage labels Nov 27, 2023
@pavolloffay
Copy link
Member

@changexd the issue is free to take. You can submit a PR to fix it.

@pavolloffay pavolloffay added the documentation Improvements or additions to documentation label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants