Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[target allocator] Pprof endpoint does not correctly handle all profile types #1478

Closed
matej-g opened this issue Feb 16, 2023 · 0 comments · Fixed by #1479
Closed

[target allocator] Pprof endpoint does not correctly handle all profile types #1478

matej-g opened this issue Feb 16, 2023 · 0 comments · Fixed by #1479

Comments

@matej-g
Copy link
Contributor

matej-g commented Feb 16, 2023

Recently, we added pprof endpoints in #1408, but it seems we are not handling all types of profiles.

For example, trying to obtain the heap profile (``) leads to 404 I response. I believe this is due to quirk in how pprof HTTP handles paths (some are under `Index` handler, others have their own handler) and how `gin` routes - we're only handling the actual index (`/`) but not other paths that belong under index handler (e.g. `/debug/pprof/heap`).

@matej-g matej-g changed the title [target allocator] Pprof endpoints do not correctly handle all profile types [target allocator] Pprof endpoint does not correctly handle all profile types Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant