Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default cipher suites configuration for webhook server #1238

Closed
kangsheng89 opened this issue Nov 10, 2022 · 5 comments · Fixed by #1244
Closed

Add default cipher suites configuration for webhook server #1238

kangsheng89 opened this issue Nov 10, 2022 · 5 comments · Fixed by #1244

Comments

@kangsheng89
Copy link
Contributor

Currently the webhook server default cipher suite from crypto/tls package.
There are 2 cipher is vulnerable on SWEET32 attack
TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA, TLS_RSA_WITH_3DES_EDE_CBC_SHA

Since webhook server is default to TLSv1.2, we can add configure to default disable cipher suite of the above, and allow the strong cipher suite.

image
The one in yellow is medium strength cipher suite
https://www.openssl.org/blog/blog/2016/08/24/sweet32/

@kangsheng89 kangsheng89 changed the title Add cipher suites configuration and defaults for webhook server Add default cipher suites configuration for webhook server Nov 10, 2022
@kangsheng89
Copy link
Contributor Author

the ciphersuite from crypto/tls provide list of cipher suite which are safe to use
https://cs.opensource.google/go/go/+/refs/tags/go1.19.3:src/crypto/tls/cipher_suites.go;l=53

@kangsheng89
Copy link
Contributor Author

Currently the #1244 only fix operator on port 9443, port 8443 need further investigation

@kangsheng89
Copy link
Contributor Author

kangsheng89 commented Nov 11, 2022

@pavolloffay as i understand port 8443 is kube-rbac-proxy, do u mind to point me where is the entrypoint for setting the server?

@pavolloffay
Copy link
Member

what is using 8443? Is it for metrics 8443?

Are you looking to configure rbac proxy https://github.com/brancz/kube-rbac-proxy? The requests from the proxy are proxied to 8080 on the operator.

@kangsheng89
Copy link
Contributor Author

what is using 8443? Is it for metrics 8443?

Are you looking to configure rbac proxy https://github.com/brancz/kube-rbac-proxy? The requests from the proxy are proxied to 8080 on the operator.
I have created this to fix it from helm-chart
open-telemetry/opentelemetry-helm-charts#501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants