Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[target-allocator] TA pod doesn't restart when changing config settings #1008

Closed
moh-osman3 opened this issue Jul 27, 2022 · 1 comment · Fixed by #1027
Closed

[target-allocator] TA pod doesn't restart when changing config settings #1008

moh-osman3 opened this issue Jul 27, 2022 · 1 comment · Fixed by #1027
Labels
area:target-allocator Issues for target-allocator

Comments

@moh-osman3
Copy link
Contributor

Trying to debug some issues I have in my statefulset cluster, and attempted to disable prometheusCR, to stop discovering serviceMonitor jobs. Ran into an issue when setting prometheusCR: false, where the target-allocator does not restart after applying these changes.

In my collector config

spec:
  mode: {{ .Values.collector.mode }}
  image: {{ .Values.collector.image }}
  replicas: 3
  targetAllocator:
    enabled: true
    image: ghcr.io/open-telemetry/opentelemetry-operator/target-allocator:latest
    serviceAccount: {{ .Release.Name }}-collector-targetallocator
    prometheusCR:
      enabled: false

What I expected

I expected the target-allocator pod to restart and the output of curl http://lightstep-collector-targetallocator:80/jobs to exclude any jobs that were discovered by serviceMonitors.

What actually happened

No restart occurred of my target-allocator pod and even after deleting the target-allocator pod (kubectl delete po target-allocator), the output of curl http://lightstep-collector-targetallocator:80/jobs was not updated to reflect disabling prometheusCR

In fact the only way to get the update I expected was to completely delete my opentelemetry namespace (collectors, target-allocator, and otel-operator) and reinstall the pods.

In case its helpful I attached the configs of the collector and target-allocator

k get OpenTelemetryCollector lightstep-collector -o yaml: bug_attachment_otc.txt

k get deployment lightstep-collector-targetallocator -o yaml: bug_attachment_ta.txt

@pavolloffay pavolloffay added the area:target-allocator Issues for target-allocator label Jul 28, 2022
@jaronoff97
Copy link
Contributor

I'm gonna look in to the fix for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:target-allocator Issues for target-allocator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants