file_input add mapstructure support

[wph95]

• test
• mapstructure
  • FileInputConfig
  • InputConfig
  • WriterConfig
  • BaseConfig
  • WriteTo

ref open-telemetry/opentelemetry-collector-contrib#2334
resolved #14

[djaglowski]

This looks good to me. However, I would like to be very cautious with this change.

Before we can be confident that all unmarshaling is the same between previous yaml and now mapstructure, I believe we need to include some additional tests.

1. We should have some "golden" config files, which are unmarshaled using both yaml and mapstructure, to ensure that the resulting config is exactly the same.
2. Especially important, we need to ensure that custom types (those defined in helper package) are unmarshaled the same in both cases.

I have added another ticket here, which I will take myself: #33

[djaglowski]

We should have some "golden" config files, which are unmarshaled using both yaml and mapstructure, to ensure that the resulting config is exactly the same.

@wph95 I have merged #40, which I believe establishes a reasonable pattern for ensuring consistency between yaml and mapstructure unmarshaling. Would you mind pulling this in and including mapstructure validation of the same cases?

[wph95]

We should have some "golden" config files, which are unmarshaled using both yaml and mapstructure, to ensure that the resulting config is exactly the same.

@wph95 I have merged #40, which I believe establishes a reasonable pattern for ensuring consistency between yaml and mapstructure unmarshaling. Would you mind pulling this in and including mapstructure validation of the same cases?

np, will try it tomorrow, #40 look great

[djaglowski]

This looks excellent.