From 12dcac8a3c062ae9f08b68ccb0a9fd218dadceff Mon Sep 17 00:00:00 2001 From: Richard Chukwu Date: Thu, 17 Oct 2024 21:33:50 +0100 Subject: [PATCH 1/5] check-links added --- .github/workflows/check-links.yaml | 51 +++++++++++++++++++++++ .github/workflows/check_links_config.json | 28 +++++++++++++ 2 files changed, 79 insertions(+) create mode 100644 .github/workflows/check-links.yaml create mode 100644 .github/workflows/check_links_config.json diff --git a/.github/workflows/check-links.yaml b/.github/workflows/check-links.yaml new file mode 100644 index 0000000000..80ec2b74c4 --- /dev/null +++ b/.github/workflows/check-links.yaml @@ -0,0 +1,51 @@ +name: check-links +on: + push: + branches: [main] + pull_request: + +concurrency: + group: ${{ github.workflow }}-${{ github.head_ref }} + cancel-in-progress: true + +permissions: + contents: read + +jobs: + changedfiles: + name: changed files + runs-on: ubuntu-latest + env: + PR_HEAD: ${{ github.event.pull_request.head.sha }} + outputs: + md: ${{ steps.changes.outputs.md }} + steps: + - name: Checkout Repo + uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 + with: + fetch-depth: 0 + - name: Get changed files + id: changes + run: | + echo "md=$(git diff --name-only --diff-filter=ACMRTUXB $(git merge-base origin/main $PR_HEAD) $PR_HEAD | grep .md$ | xargs)" >> $GITHUB_OUTPUT + + check-links: + runs-on: ubuntu-latest + needs: changedfiles + if: ${{needs.changedfiles.outputs.md}} + steps: + - name: Checkout Repo + uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 + with: + fetch-depth: 0 + + - name: Install markdown-link-check + run: npm install + + - name: Run markdown-link-check + run: | + npx --no -- markdown-link-check \ + --verbose \ + --config .github/workflows/check_links_config.json \ + ${{needs.changedfiles.outputs.md}} \ + || { echo "Check that anchor links are lowercase"; exit 1; } diff --git a/.github/workflows/check_links_config.json b/.github/workflows/check_links_config.json new file mode 100644 index 0000000000..2ed875f727 --- /dev/null +++ b/.github/workflows/check_links_config.json @@ -0,0 +1,28 @@ +{ + "ignorePatterns": [ + { + "pattern": "http(s)?://\\d+\\.\\d+\\.\\d+\\.\\d+" + }, + { + "pattern": "http(s)?://localhost" + }, + { + "pattern": "http(s)?://example.com" + }, + { + "pattern": "https://docs.aws.amazon.com" + }, + { + "pattern": "https://console.aws.amazon.com" + } + ], + "aliveStatusCodes": [429, 200], + "httpHeaders": [ + { + "urls": ["https://docs.aws.amazon.com", "https://docs.github.com/"], + "headers": { + "Accept-Encoding": "zstd, br, gzip, deflate" + } + } + ] +} From 9d8ad7cce32ef07ba0025f80915cafc045302dd9 Mon Sep 17 00:00:00 2001 From: Richard Chukwu Date: Mon, 21 Oct 2024 20:59:36 +0100 Subject: [PATCH 2/5] Review --- .github/workflows/check-links.yaml | 5 ----- ...CoreApp,Version=v6.0.AssemblyAttributes.cs | 4 ++++ .../Debug/net6.0/AwsSdkSample.AssemblyInfo.cs | 22 +++++++++++++++++++ .../AwsSdkSample.AssemblyInfoInputs.cache | 1 + ....GeneratedMSBuildEditorConfig.editorconfig | 15 +++++++++++++ 5 files changed, 42 insertions(+), 5 deletions(-) create mode 100644 dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/.NETCoreApp,Version=v6.0.AssemblyAttributes.cs create mode 100644 dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfo.cs create mode 100644 dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfoInputs.cache create mode 100644 dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.GeneratedMSBuildEditorConfig.editorconfig diff --git a/.github/workflows/check-links.yaml b/.github/workflows/check-links.yaml index 80ec2b74c4..37bd673366 100644 --- a/.github/workflows/check-links.yaml +++ b/.github/workflows/check-links.yaml @@ -6,11 +6,6 @@ on: concurrency: group: ${{ github.workflow }}-${{ github.head_ref }} - cancel-in-progress: true - -permissions: - contents: read - jobs: changedfiles: name: changed files diff --git a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/.NETCoreApp,Version=v6.0.AssemblyAttributes.cs b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/.NETCoreApp,Version=v6.0.AssemblyAttributes.cs new file mode 100644 index 0000000000..ed9269506e --- /dev/null +++ b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/.NETCoreApp,Version=v6.0.AssemblyAttributes.cs @@ -0,0 +1,4 @@ +// +using System; +using System.Reflection; +[assembly: global::System.Runtime.Versioning.TargetFrameworkAttribute(".NETCoreApp,Version=v6.0", FrameworkDisplayName = ".NET 6.0")] diff --git a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfo.cs b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfo.cs new file mode 100644 index 0000000000..52de321640 --- /dev/null +++ b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfo.cs @@ -0,0 +1,22 @@ +//------------------------------------------------------------------------------ +// +// This code was generated by a tool. +// +// Changes to this file may cause incorrect behavior and will be lost if +// the code is regenerated. +// +//------------------------------------------------------------------------------ + +using System; +using System.Reflection; + +[assembly: System.Reflection.AssemblyCompanyAttribute("AwsSdkSample")] +[assembly: System.Reflection.AssemblyConfigurationAttribute("Debug")] +[assembly: System.Reflection.AssemblyFileVersionAttribute("1.0.0.0")] +[assembly: System.Reflection.AssemblyInformationalVersionAttribute("1.0.0+12dcac8a3c062ae9f08b68ccb0a9fd218dadceff")] +[assembly: System.Reflection.AssemblyProductAttribute("AwsSdkSample")] +[assembly: System.Reflection.AssemblyTitleAttribute("AwsSdkSample")] +[assembly: System.Reflection.AssemblyVersionAttribute("1.0.0.0")] + +// Generated by the MSBuild WriteCodeFragment class. + diff --git a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfoInputs.cache b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfoInputs.cache new file mode 100644 index 0000000000..41ca6deae8 --- /dev/null +++ b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfoInputs.cache @@ -0,0 +1 @@ +f51ad78188229488c5ce47b8a0e66d0eabafb9b692073a68b5b3ce4131b0e71c diff --git a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.GeneratedMSBuildEditorConfig.editorconfig b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.GeneratedMSBuildEditorConfig.editorconfig new file mode 100644 index 0000000000..cb6349c0dd --- /dev/null +++ b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.GeneratedMSBuildEditorConfig.editorconfig @@ -0,0 +1,15 @@ +is_global = true +build_property.TargetFramework = net6.0 +build_property.TargetPlatformMinVersion = +build_property.UsingMicrosoftNETSdkWeb = +build_property.ProjectTypeGuids = +build_property.InvariantGlobalization = +build_property.PlatformNeutralAssembly = +build_property.EnforceExtendedAnalyzerRules = +build_property._SupportedPlatformList = Linux,macOS,Windows +build_property.RootNamespace = AwsSdkSample +build_property.ProjectDir = C:\Users\hp\Desktop\Outreachy Contribution Phase\OpenTelemetry\OL\opentelemetry-lambda\dotnet\sample-apps\aws-sdk\wrapper\SampleApps\AwsSdkSample\ +build_property.EnableComHosting = +build_property.EnableGeneratedComInterfaceComImportInterop = +build_property.EffectiveAnalysisLevelStyle = 6.0 +build_property.EnableCodeStyleSeverity = From c684b3b773c75a3a55a32e70f64aeb105c3052dd Mon Sep 17 00:00:00 2001 From: Richard Chukwu Date: Sat, 26 Oct 2024 06:53:17 +0100 Subject: [PATCH 3/5] Dotnet changes removed --- .../wrapper/SampleApps/AwsSdkSample.sln | 25 ------------------- 1 file changed, 25 deletions(-) delete mode 100644 dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample.sln diff --git a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample.sln b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample.sln deleted file mode 100644 index 4551fc2238..0000000000 --- a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample.sln +++ /dev/null @@ -1,25 +0,0 @@ - -Microsoft Visual Studio Solution File, Format Version 12.00 -# Visual Studio Version 16 -VisualStudioVersion = 16.0.31112.23 -MinimumVisualStudioVersion = 10.0.40219.1 -Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AwsSdkSample", "AwsSdkSample\AwsSdkSample.csproj", "{5D474E1F-C49C-486D-9398-5D8523D7C722}" -EndProject -Global - GlobalSection(SolutionConfigurationPlatforms) = preSolution - Debug|Any CPU = Debug|Any CPU - Release|Any CPU = Release|Any CPU - EndGlobalSection - GlobalSection(ProjectConfigurationPlatforms) = postSolution - {5D474E1F-C49C-486D-9398-5D8523D7C722}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {5D474E1F-C49C-486D-9398-5D8523D7C722}.Debug|Any CPU.Build.0 = Debug|Any CPU - {5D474E1F-C49C-486D-9398-5D8523D7C722}.Release|Any CPU.ActiveCfg = Release|Any CPU - {5D474E1F-C49C-486D-9398-5D8523D7C722}.Release|Any CPU.Build.0 = Release|Any CPU - EndGlobalSection - GlobalSection(SolutionProperties) = preSolution - HideSolutionNode = FALSE - EndGlobalSection - GlobalSection(ExtensibilityGlobals) = postSolution - SolutionGuid = {EB75E573-89CA-4362-8A48-148AB6295EF8} - EndGlobalSection -EndGlobal From 4daf044db411bd1846c750906b172ad83dd5e479 Mon Sep 17 00:00:00 2001 From: Richard Chukwu <79311274+RichardChukwu@users.noreply.github.com> Date: Mon, 28 Oct 2024 16:53:10 +0100 Subject: [PATCH 4/5] Delete dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0 directory Unwanted --- ...CoreApp,Version=v6.0.AssemblyAttributes.cs | 4 ---- .../Debug/net6.0/AwsSdkSample.AssemblyInfo.cs | 22 ------------------- .../AwsSdkSample.AssemblyInfoInputs.cache | 1 - ....GeneratedMSBuildEditorConfig.editorconfig | 15 ------------- 4 files changed, 42 deletions(-) delete mode 100644 dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/.NETCoreApp,Version=v6.0.AssemblyAttributes.cs delete mode 100644 dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfo.cs delete mode 100644 dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfoInputs.cache delete mode 100644 dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.GeneratedMSBuildEditorConfig.editorconfig diff --git a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/.NETCoreApp,Version=v6.0.AssemblyAttributes.cs b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/.NETCoreApp,Version=v6.0.AssemblyAttributes.cs deleted file mode 100644 index ed9269506e..0000000000 --- a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/.NETCoreApp,Version=v6.0.AssemblyAttributes.cs +++ /dev/null @@ -1,4 +0,0 @@ -// -using System; -using System.Reflection; -[assembly: global::System.Runtime.Versioning.TargetFrameworkAttribute(".NETCoreApp,Version=v6.0", FrameworkDisplayName = ".NET 6.0")] diff --git a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfo.cs b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfo.cs deleted file mode 100644 index 52de321640..0000000000 --- a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfo.cs +++ /dev/null @@ -1,22 +0,0 @@ -//------------------------------------------------------------------------------ -// -// This code was generated by a tool. -// -// Changes to this file may cause incorrect behavior and will be lost if -// the code is regenerated. -// -//------------------------------------------------------------------------------ - -using System; -using System.Reflection; - -[assembly: System.Reflection.AssemblyCompanyAttribute("AwsSdkSample")] -[assembly: System.Reflection.AssemblyConfigurationAttribute("Debug")] -[assembly: System.Reflection.AssemblyFileVersionAttribute("1.0.0.0")] -[assembly: System.Reflection.AssemblyInformationalVersionAttribute("1.0.0+12dcac8a3c062ae9f08b68ccb0a9fd218dadceff")] -[assembly: System.Reflection.AssemblyProductAttribute("AwsSdkSample")] -[assembly: System.Reflection.AssemblyTitleAttribute("AwsSdkSample")] -[assembly: System.Reflection.AssemblyVersionAttribute("1.0.0.0")] - -// Generated by the MSBuild WriteCodeFragment class. - diff --git a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfoInputs.cache b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfoInputs.cache deleted file mode 100644 index 41ca6deae8..0000000000 --- a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.AssemblyInfoInputs.cache +++ /dev/null @@ -1 +0,0 @@ -f51ad78188229488c5ce47b8a0e66d0eabafb9b692073a68b5b3ce4131b0e71c diff --git a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.GeneratedMSBuildEditorConfig.editorconfig b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.GeneratedMSBuildEditorConfig.editorconfig deleted file mode 100644 index cb6349c0dd..0000000000 --- a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample/obj/Debug/net6.0/AwsSdkSample.GeneratedMSBuildEditorConfig.editorconfig +++ /dev/null @@ -1,15 +0,0 @@ -is_global = true -build_property.TargetFramework = net6.0 -build_property.TargetPlatformMinVersion = -build_property.UsingMicrosoftNETSdkWeb = -build_property.ProjectTypeGuids = -build_property.InvariantGlobalization = -build_property.PlatformNeutralAssembly = -build_property.EnforceExtendedAnalyzerRules = -build_property._SupportedPlatformList = Linux,macOS,Windows -build_property.RootNamespace = AwsSdkSample -build_property.ProjectDir = C:\Users\hp\Desktop\Outreachy Contribution Phase\OpenTelemetry\OL\opentelemetry-lambda\dotnet\sample-apps\aws-sdk\wrapper\SampleApps\AwsSdkSample\ -build_property.EnableComHosting = -build_property.EnableGeneratedComInterfaceComImportInterop = -build_property.EffectiveAnalysisLevelStyle = 6.0 -build_property.EnableCodeStyleSeverity = From 0cb7103bc342a2e9a31354f5843ce74f32ecce36 Mon Sep 17 00:00:00 2001 From: Richard Chukwu <79311274+RichardChukwu@users.noreply.github.com> Date: Mon, 28 Oct 2024 19:15:26 +0100 Subject: [PATCH 5/5] Undo deleted AwsSdkSample.sln --- .../wrapper/SampleApps/AwsSdkSample.sln | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample.sln diff --git a/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample.sln b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample.sln new file mode 100644 index 0000000000..4551fc2238 --- /dev/null +++ b/dotnet/sample-apps/aws-sdk/wrapper/SampleApps/AwsSdkSample.sln @@ -0,0 +1,25 @@ + +Microsoft Visual Studio Solution File, Format Version 12.00 +# Visual Studio Version 16 +VisualStudioVersion = 16.0.31112.23 +MinimumVisualStudioVersion = 10.0.40219.1 +Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AwsSdkSample", "AwsSdkSample\AwsSdkSample.csproj", "{5D474E1F-C49C-486D-9398-5D8523D7C722}" +EndProject +Global + GlobalSection(SolutionConfigurationPlatforms) = preSolution + Debug|Any CPU = Debug|Any CPU + Release|Any CPU = Release|Any CPU + EndGlobalSection + GlobalSection(ProjectConfigurationPlatforms) = postSolution + {5D474E1F-C49C-486D-9398-5D8523D7C722}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {5D474E1F-C49C-486D-9398-5D8523D7C722}.Debug|Any CPU.Build.0 = Debug|Any CPU + {5D474E1F-C49C-486D-9398-5D8523D7C722}.Release|Any CPU.ActiveCfg = Release|Any CPU + {5D474E1F-C49C-486D-9398-5D8523D7C722}.Release|Any CPU.Build.0 = Release|Any CPU + EndGlobalSection + GlobalSection(SolutionProperties) = preSolution + HideSolutionNode = FALSE + EndGlobalSection + GlobalSection(ExtensibilityGlobals) = postSolution + SolutionGuid = {EB75E573-89CA-4362-8A48-148AB6295EF8} + EndGlobalSection +EndGlobal