From 6a1957c791152c8572db2507e6ab36714adae200 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Wed, 14 Feb 2024 10:13:56 +0100 Subject: [PATCH 1/2] fix(otlp-transformer): only use BigInt inside hrTimeToNanos() --- experimental/packages/otlp-transformer/src/common/index.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/experimental/packages/otlp-transformer/src/common/index.ts b/experimental/packages/otlp-transformer/src/common/index.ts index 00dcccfb05..96d281bad6 100644 --- a/experimental/packages/otlp-transformer/src/common/index.ts +++ b/experimental/packages/otlp-transformer/src/common/index.ts @@ -18,9 +18,8 @@ import type { OtlpEncodingOptions, Fixed64, LongBits } from './types'; import { HrTime } from '@opentelemetry/api'; import { hexToBinary, hrTimeToNanoseconds } from '@opentelemetry/core'; -const NANOSECONDS = BigInt(1_000_000_000); - export function hrTimeToNanos(hrTime: HrTime): bigint { + const NANOSECONDS = BigInt(1_000_000_000); return BigInt(hrTime[0]) * NANOSECONDS + BigInt(hrTime[1]); } From 54418149a37a91a1972104b19013d2429976ac3e Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Wed, 14 Feb 2024 10:34:25 +0100 Subject: [PATCH 2/2] fix: changelog --- experimental/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 01b1b3d688..c78f489069 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -18,6 +18,7 @@ All notable changes to experimental packages in this project will be documented * fix(sdk-node): allow using samplers when the exporter is defined in the environment [#4394](https://github.com/open-telemetry/opentelemetry-js/pull/4394) @JacksonWeber * fix(instrumentation): normalize paths for internal files in scoped packages [#4467](https://github.com/open-telemetry/opentelemetry-js/pull/4467) @pichlermarc * Fixes a bug where, on Windows, internal files on scoped packages would not be instrumented. +* fix(otlp-transformer): only use BigInt inside hrTimeToNanos() [#4484](https://github.com/open-telemetry/opentelemetry-js/pull/4484) @pichlermarc ### :books: (Refine Doc)