From 4d68eab0d2201b775fa056267e61ba70cc5463ad Mon Sep 17 00:00:00 2001 From: Bartlomiej Obecny Date: Tue, 2 Nov 2021 21:38:42 +0100 Subject: [PATCH 1/2] fix: fixing compatibility versions for detectors --- .../opentelemetry-sdk-node/package.json | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/experimental/packages/opentelemetry-sdk-node/package.json b/experimental/packages/opentelemetry-sdk-node/package.json index 28a9e746c1..2cec14bdf1 100644 --- a/experimental/packages/opentelemetry-sdk-node/package.json +++ b/experimental/packages/opentelemetry-sdk-node/package.json @@ -42,15 +42,15 @@ "access": "public" }, "dependencies": { - "@opentelemetry/api-metrics": "0.26.0", - "@opentelemetry/core": "1.0.0", - "@opentelemetry/instrumentation": "0.26.0", - "@opentelemetry/resource-detector-aws": "0.24.0", - "@opentelemetry/resource-detector-gcp": "0.24.0", - "@opentelemetry/resources": "1.0.0", - "@opentelemetry/sdk-metrics-base": "0.26.0", - "@opentelemetry/sdk-trace-base": "1.0.0", - "@opentelemetry/sdk-trace-node": "1.0.0" + "@opentelemetry/api-metrics": "~0.26.0", + "@opentelemetry/core": "~1.0.0", + "@opentelemetry/instrumentation": "~0.26.0", + "@opentelemetry/resource-detector-aws": "~1.0.0", + "@opentelemetry/resource-detector-gcp": "~0.26.0", + "@opentelemetry/resources": "~1.0.0", + "@opentelemetry/sdk-metrics-base": "~0.26.0", + "@opentelemetry/sdk-trace-base": "~1.0.0", + "@opentelemetry/sdk-trace-node": "~1.0.0" }, "peerDependencies": { "@opentelemetry/api": ">=1.0.0 <1.1.0" From b0c92ed7684fdbc8d6ada0a88ade874ae5840a4f Mon Sep 17 00:00:00 2001 From: Bartlomiej Obecny Date: Wed, 3 Nov 2021 00:16:44 +0100 Subject: [PATCH 2/2] chore: trying to fix tests --- experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts b/experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts index 5b593cba4c..7bfc913ce1 100644 --- a/experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts +++ b/experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts @@ -131,7 +131,7 @@ describe('Node SDK', () => { assert.ok(metrics.getMeterProvider() instanceof NoopMeterProvider); assert.ok( - context['_getContextManager']() instanceof DefaultContextManager + context['_getContextManager']().constructor.name === DefaultContextManager.name ); assert.ok( propagation['_getGlobalPropagator']() instanceof CompositePropagator @@ -154,7 +154,7 @@ describe('Node SDK', () => { assert.ok(metrics.getMeterProvider() instanceof NoopMeterProvider); assert.ok( - context['_getContextManager']() instanceof DefaultContextManager + context['_getContextManager']().constructor.name === DefaultContextManager.name ); assert.ok( propagation['_getGlobalPropagator']() instanceof CompositePropagator