Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port stackdriver trace exporter from OpenCensus. #530

Closed
naseemkullah opened this issue Nov 13, 2019 · 6 comments
Closed

port stackdriver trace exporter from OpenCensus. #530

naseemkullah opened this issue Nov 13, 2019 · 6 comments
Assignees

Comments

@naseemkullah
Copy link
Member

Does one exist for js?

@mayurkale22
Copy link
Member

Not yet, but we can port stackdriver trace exporter from OpenCensus.

@mayurkale22 mayurkale22 added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 13, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.4 milestone Nov 13, 2019
@naseemkullah naseemkullah changed the title Stackdriver exporter? port stackdriver trace exporter from OpenCensus. Nov 13, 2019
@dyladan
Copy link
Member

dyladan commented Nov 25, 2019

I'll take this

@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Nov 25, 2019
@mayurkale22
Copy link
Member

The reference implementation has both trace and monitoring (metrics) exporters in the same package, maybe we should follow the same pattern here and include trace exporter first and monitoring later.

@dyladan
Copy link
Member

dyladan commented Nov 25, 2019

Depending on how much code is shared I would prefer to actually keep them as separate packages. If a customer only needs one of them we are unnecessarily increasing their deployment size if they are together.

If there is shared code, we could make it a separate package?

  • @opentelemetry/exporter-stackdriver-cloudtrace
  • @opentelemetry/exporter-stackdriver-monitoring
  • @opentelemetry/exporter-stackdriver-base
    • Only if there is enough shared code to justify a third package.

All three could live in packages/opentelemetry-stackdriver/ directory similar to pg and pg-pool

@mayurkale22
Copy link
Member

AFAIK only resources(common-utils) stuff is shared between these two.

If a customer only needs one of them we are unnecessarily increasing their deployment size if they are together.

I completely agree with this and looks like OpenTelemetry Go also implemented like that : https://github.com/open-telemetry/opentelemetry-go/tree/master/exporter.

@mayurkale22
Copy link
Member

Closing via #648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants