Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen peerDependency range for @opentelemetry/api #4815

Closed
mydea opened this issue Jun 21, 2024 · 0 comments · Fixed by #4816
Closed

Widen peerDependency range for @opentelemetry/api #4815

mydea opened this issue Jun 21, 2024 · 0 comments · Fixed by #4816

Comments

@mydea
Copy link
Contributor

mydea commented Jun 21, 2024

Today, some packages have this in their package.json:

"peerDependencies": {
    "@opentelemetry/api": ">=1.3.0 <1.10.0"
  },

This is true for:

  • sdk-node
  • otlp-transformer
  • propagator-aws-xray-lambda
  • sdk-metrics

IMHO it is not helpful to have this be so tightly defined - why can't it just be >= 1.3.0? Minor versions should be backwards compatible anyhow, so this should be totally safe to do.

With the current setup, you can run into cases where you end up with multiple versions of @opentelemetry/api if you have different instrumentation package versions, which is not helpful at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant