Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Jaeger Remote Sampler as defined by the specification #4534

Closed
3 tasks
pichlermarc opened this issue Mar 8, 2024 · 3 comments · Fixed by #4589
Closed
3 tasks

Implement Jaeger Remote Sampler as defined by the specification #4534

pichlermarc opened this issue Mar 8, 2024 · 3 comments · Fixed by #4589
Assignees
@legalimpurity
Labels
never-stale spec-feature This is a request to implement a new feature which is already specified by the OTel specification triage:accepted This feature has been accepted type:feature A feature with no sub-issues to address

Comments

@pichlermarc
Copy link
Member

We currently don't have an implementation of the JaegerRemoteSampler as defined in the specification.

To complete this issue:

  • create a new experimental package @opentelemetry/sampler-jaeger-remote (this can be done in a separate PR to keep the actual implementation PR smaller)
  • implement the sampler based on the specification
  • add tests
@pichlermarc pichlermarc added spec-feature This is a request to implement a new feature which is already specified by the OTel specification triage:accepted This feature has been accepted type:feature A feature with no sub-issues to address needs:code-contribution This feature/bug is ready to implement labels Mar 8, 2024
@pichlermarc pichlermarc mentioned this issue Mar 8, 2024
Closed
2 tasks
@pichlermarc pichlermarc added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Mar 8, 2024
@legalimpurity
Copy link
Contributor

@pichlermarc I would like to pick this up.

@pichlermarc
Copy link
Member Author

Thanks for picking this up. It's yours @legalimpurity 🙂

@legalimpurity legalimpurity mentioned this issue Mar 27, 2024
Merged
3 tasks
@pichlermarc pichlermarc removed up-for-grabs Good for taking. Extra help will be provided by maintainers needs:code-contribution This feature/bug is ready to implement labels Apr 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legalimpurity legalimpurity

Labels
never-stale spec-feature This is a request to implement a new feature which is already specified by the OTel specification triage:accepted This feature has been accepted type:feature A feature with no sub-issues to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(jaeger-remote-sampler): Implement jaeger remote sampler legalimpurity/opentelemetry-js
2 participants
@legalimpurity @pichlermarc