Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: IsRecordingEvents -> IsRecording #448

Closed
mayurkale22 opened this issue Oct 21, 2019 · 2 comments · Fixed by #454
Closed

Fix: IsRecordingEvents -> IsRecording #448

mayurkale22 opened this issue Oct 21, 2019 · 2 comments · Fixed by #454
Assignees
Labels
Milestone

Comments

@mayurkale22
Copy link
Member

Original issue: open-telemetry/opentelemetry-specification#44

Reference code:

/**
* Returns the flag whether this span will be recorded.
*
* @returns true if this Span is active and recording information like events
* with the AddEvent operation and attributes using setAttributes.
*/
isRecordingEvents(): boolean;

@mayurkale22 mayurkale22 added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Oct 21, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.2 milestone Oct 21, 2019
@mayurkale22 mayurkale22 added the good first issue Good for newcomers label Oct 22, 2019
@xiao-lix
Copy link
Contributor

@mayurkale22 Would it be fine if I take this?

@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Oct 22, 2019
@mayurkale22
Copy link
Member Author

@mayurkale22 Would it be fine if I take this?

Sure, I have assigned to you. Thanks for taking the initiative. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants