Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the histogram bucket metric advise API #3722

Closed
weyert opened this issue Apr 11, 2023 · 3 comments · Fixed by #3876
Closed

Implement the histogram bucket metric advise API #3722

weyert opened this issue Apr 11, 2023 · 3 comments · Fixed by #3876

Comments

@weyert
Copy link
Contributor

weyert commented Apr 11, 2023

Is your feature request related to a problem? Please describe.

Recently a new specification for the histogram bucket metric advise API or hint API got merged in the opentelemetry-specification repository: open-telemetry/opentelemetry-specification#3216

Describe the solution you'd like

Implement the above mentioned specification

Describe alternatives you've considered

None

Additional context

None

@weyert
Copy link
Contributor Author

weyert commented Apr 11, 2023

I think we can add a new advice-property to the InstrumentDescriptor that allows to describe the histogram buckets in the API and then in the SDK we somehow could check if this advice-property is populated when the backing Histogram instrument gets created and then when a view does not already exist for the instrument, register our own view that represents the config defined in the advice-property.

What this approach work?

@pichlermarc
Copy link
Member

I think we can add a new advice-property to the InstrumentDescriptor that allows to describe the histogram buckets in the API and then in the SDK we somehow could check if this advice-property is populated when the backing Histogram instrument gets created and then when a view does not already exist for the instrument, register our own view that represents the config defined in the advice-property.

As far as I understand the spec, we cannot use a view for this as we are not allowed to override the MetricReader's preference with the hint. 🤔

So if the MetricReader requests an ExponentialHistogramAggregation, we'd not be allowed to override it with an ExplictBucketHistogramAggregation even though the hint is present - hints would only influence the default aggregation.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants