Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old runtimes #3583

Closed
dyladan opened this issue Feb 1, 2023 · 3 comments
Closed

Deprecate old runtimes #3583

dyladan opened this issue Feb 1, 2023 · 3 comments
Assignees
Labels
contribfest These small and isolated issues are suitable for Kubecon Contribfest never-stale triage:accepted This feature has been accepted

Comments

@dyladan
Copy link
Member

dyladan commented Feb 1, 2023

THIS IS A BREAKING CHANGE. PLEASE MAKE PR TO THE next BRANCH FOR INCLUSION IN THE 2.0 RELEASE

Remove testing and documentation of support for unsupported runtimes and document the following policy:

Old runtimes defined as runtimes no longer supported by NodeJS. When a LTS NodeJS version reaches end of life, we will release a new major version which drops support for it. The previous major version will continue to receive security and p1 bug fixes for 1 year after the new major version release.

@dyladan dyladan added this to the OpenTelemetry 2.0 milestone Feb 1, 2023
@pichlermarc
Copy link
Member

We should also remove existing code that soley exists for the purpose of keeping old runtimes alive. See #3689.

@pichlermarc
Copy link
Member

pichlermarc commented Sep 7, 2023

once we've drop support for node 14, we'll need to remove the workaround for nx not supporting Node 14 anymore:

# temporary fix for https://github.com/nrwl/nx/issues/19022
- run: npm install --save-dev nx@16.7.4 @nx/devkit@16.7.4
if: ${{ matrix.node_version == '14' }}

We can then close #4123

@pichlermarc
Copy link
Member

pichlermarc commented Sep 7, 2023

We'll also need to drop the node v14 (possibly also v16) workarounds here:

- run: npm install -g npm@latest
if: ${{ matrix.node_version == '18' || matrix.node_version == '20' }}
# npm@10.0.0 drops support for Node.js v14 and v16
- run: npm install -g npm@"<10.0.0"
if: ${{ matrix.node_version == '14' || matrix.node_version == '16' }}

@dyladan dyladan added triage and removed triage labels Sep 27, 2023
@pichlermarc pichlermarc added the triage:accepted This feature has been accepted label Oct 4, 2023
@dyladan dyladan self-assigned this Oct 25, 2023
@dyladan dyladan added the contribfest These small and isolated issues are suitable for Kubecon Contribfest label Nov 8, 2023
@dyladan dyladan closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest These small and isolated issues are suitable for Kubecon Contribfest never-stale triage:accepted This feature has been accepted
Projects
None yet
Development

No branches or pull requests

2 participants