Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove got temporarily #3347

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Remove got temporarily #3347

merged 1 commit into from
Oct 19, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 19, 2022

Fixes #3344

Removes the got dependency which means we're not testing the http instrumentation with it anymore for now. This is a temporary solution while we figure out something more long term.

@dyladan dyladan requested a review from a team October 19, 2022 13:49
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #3347 (5175618) into main (ec8ff16) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3347   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files         241      241           
  Lines        7260     7260           
  Branches     1507     1507           
=======================================
  Hits         6785     6785           
  Misses        475      475           
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@weyert
Copy link
Contributor

weyert commented Oct 19, 2022

Maybe can use undici for the tests?
Keep forgetting it doesn't support Node v14

@Flarna
Copy link
Member

Flarna commented Oct 19, 2022

Maybe can use undici for the tests?

The http instrumentation doesn't support undici. got is used as one http client to verify that http client instrumentation captures the data correct.

@dyladan
Copy link
Member Author

dyladan commented Oct 19, 2022

Maybe can use undici for the tests?

The http instrumentation doesn't support undici. got is used as one http client to verify that http client instrumentation captures the data correct.

Just to expand on this. undici doesn't use the underlying http/https modules and would require its own instrumentation. It uses diagnostic channels so maybe that is a good way to go about instrumenting it in the future.

@dyladan dyladan merged commit 6ede1ee into open-telemetry:main Oct 19, 2022
@dyladan dyladan deleted the remove-got branch October 19, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean build of the project will not compile
4 participants