Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eslint-config-airbnb-base dependency #2922

Closed
1 of 2 tasks
blumamir opened this issue Apr 24, 2022 · 1 comment · Fixed by #2955
Closed
1 of 2 tasks

Remove eslint-config-airbnb-base dependency #2922

blumamir opened this issue Apr 24, 2022 · 1 comment · Fixed by #2955
Labels
good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@blumamir
Copy link
Member

This repo has dependency on eslint-config-airbnb-base, but it is used only for examples packages:

  1. here
  2. here
  3. and here

I wonder if it's intentional or just leftovers from previous chores that can be cleaned.
I also wonder if we should unify the linting across the repo (both examples and core packages)

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first
@legendecas
Copy link
Member

I believe they are just leftovers and can be cleaned up.

For unifying linter rules across repos, I'd find adopting a mature linter rule package would be a maintainable way. Or we'd have to sync the rules across the repos every time we changed it. I recall that we previously used gts for a while but moved away from it (#2204, I think prettier is the one to blame for breaking changes in semver minor).

@dyladan dyladan added good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers labels Apr 27, 2022
@dyladan dyladan changed the title eslint-config-airbnb-base: where should we use it? Remove eslint-config-airbnb-base dependency Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants