Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of api.SpanAttributes with api.Attributes #2674

Closed
dyladan opened this issue Dec 16, 2021 · 8 comments · Fixed by #2881
Closed

Replace use of api.SpanAttributes with api.Attributes #2674

dyladan opened this issue Dec 16, 2021 · 8 comments · Fixed by #2881
Labels

Comments

@dyladan
Copy link
Member

dyladan commented Dec 16, 2021

LGTM. Since we are marking SpanAttributes as deprecated, should we have a follow up task to replace usage with Attributes?

Originally posted by @mwear in open-telemetry/opentelemetry-js-api#142 (review)

@blumamir
Copy link
Member

I vote yes.
That would also mean upgrading to api version 1.1.0
Is it possible that the peerDependecies protection be ignored and the user will have installed an old api version and new SDK version? causing them to fail

I guess we cannot avoid that, but wondering what problems users might face.

@blumamir
Copy link
Member

I looked again and the change in api package is only in types, so it for sure expected to work in user code.
So positive yes for this change 👍

@dyladan
Copy link
Member Author

dyladan commented Jan 10, 2022

Ah i didn't make it clear from the issue description this was something we already agreed upon, I just copied the original message from the previous thread

@dyladan dyladan added the Agreed label Jan 10, 2022
@blumamir blumamir added good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jan 10, 2022
@RazGvili
Copy link
Contributor

Hi,
I would like to work on it, please assign it to me.

Thanks!

@legendecas legendecas removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jan 10, 2022
@RazGvili
Copy link
Contributor

Hi @dyladan,
To complete this task ill need opentelemetry-js-api version 1.1.0 to be published, it seems that there is a PR for that.

Do you know the schedule for publishing 1.1.0?
current published version: 1.0.4(npm)

Thanks!

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@dyladan
Copy link
Member Author

dyladan commented Apr 6, 2022

@RazGvili are you still planning to work on this? The 1.1 API was released

@dyladan
Copy link
Member Author

dyladan commented Apr 6, 2022

This is fixed by #2881

@dyladan dyladan linked a pull request Apr 6, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants