From be8a185770669573f9a42f312ec28a2dd245867c Mon Sep 17 00:00:00 2001
From: vmarchaud <contact@vmarchaud.fr>
Date: Sat, 8 May 2021 11:01:11 +0200
Subject: [PATCH] chore: add tests

---
 .../test/BasicTracerProvider.test.ts          | 65 ++++++++++++++-----
 1 file changed, 48 insertions(+), 17 deletions(-)

diff --git a/packages/opentelemetry-tracing/test/BasicTracerProvider.test.ts b/packages/opentelemetry-tracing/test/BasicTracerProvider.test.ts
index 07e6219ecf8..fabf9ab4029 100644
--- a/packages/opentelemetry-tracing/test/BasicTracerProvider.test.ts
+++ b/packages/opentelemetry-tracing/test/BasicTracerProvider.test.ts
@@ -38,7 +38,14 @@ import {
 import { Resource } from '@opentelemetry/resources';
 import * as assert from 'assert';
 import * as sinon from 'sinon';
-import { BasicTracerProvider, NoopSpanProcessor, Span } from '../src';
+import {
+  BasicTracerProvider,
+  NoopSpanProcessor,
+  Span,
+  InMemorySpanExporter,
+  SpanExporter,
+  BatchSpanProcessor,
+} from '../src';
 
 describe('BasicTracerProvider', () => {
   let removeEvent: Function | undefined;
@@ -128,22 +135,6 @@ describe('BasicTracerProvider', () => {
       const tracer = new BasicTracerProvider();
       assert.ok(tracer.activeSpanProcessor instanceof NoopSpanProcessor);
     });
-
-    it('warns if there is no exporter registered with a given name', () => {
-      const warnStub = sinon.spy(diag, 'warn');
-
-      envSource.OTEL_TRACES_EXPORTER = 'missing-exporter';
-      const provider = new BasicTracerProvider({});
-      provider.register();
-
-      assert.ok(
-        warnStub.calledOnceWithExactly(
-          'Exporter "missing-exporter" requested through environment variable is unavailable.'
-        )
-      );
-      warnStub.restore();
-      envSource.OTEL_TRACES_EXPORTER = 'none';
-    });
   });
 
   describe('.register()', () => {
@@ -233,6 +224,46 @@ describe('BasicTracerProvider', () => {
         warnStub.restore();
       });
     });
+
+    describe('exporter', () => {
+      class CustomTracerProvider extends BasicTracerProvider {
+        protected _getSpanExporter(name: string): SpanExporter | undefined {
+          return name === 'memory'
+            ? new InMemorySpanExporter()
+            : BasicTracerProvider._registeredExporters.get(name)?.();
+        }
+      }
+
+      afterEach(() => {
+        delete envSource.OTEL_TRACES_EXPORTER;
+      });
+
+      it('warns if there is no exporter registered with a given name', () => {
+        const warnStub = sinon.spy(diag, 'warn');
+
+        envSource.OTEL_TRACES_EXPORTER = 'missing-exporter';
+        const provider = new BasicTracerProvider({});
+        provider.register();
+
+        assert.ok(
+          warnStub.calledOnceWithExactly(
+            'Exporter "missing-exporter" requested through environment variable is unavailable.'
+          )
+        );
+        warnStub.restore();
+      });
+
+      it('register register correct trace exporter', () => {
+        envSource.OTEL_TRACES_EXPORTER = 'memory';
+        const provider = new CustomTracerProvider({});
+        provider.register();
+        const processor = provider.getActiveSpanProcessor();
+        assert(processor instanceof BatchSpanProcessor);
+        // @ts-expect-error access configured to verify its the correct one
+        const exporter = processor._exporter;
+        assert(exporter instanceof InMemorySpanExporter);
+      });
+    });
   });
 
   describe('.startSpan()', () => {