From a5e90c4301fd2e977d74d49b2b141e3adc0da17b Mon Sep 17 00:00:00 2001 From: naseemkullah Date: Mon, 25 Jan 2021 08:07:56 -0500 Subject: [PATCH] fix: replace deprecaded url.parse with new url.URL() Signed-off-by: naseemkullah --- .../src/PrometheusExporter.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts b/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts index 697bc0139f4..e40cda06dc6 100644 --- a/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts +++ b/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts @@ -74,7 +74,9 @@ export class PrometheusExporter implements MetricExporter { ).replace(/^([^/])/, '/$1'); if (config.preventServerStart !== true) { - this.startServer().then(callback).catch(err => this._logger.error(err)); + this.startServer() + .then(callback) + .catch(err => this._logger.error(err)); } else if (callback) { callback(); } @@ -176,7 +178,7 @@ export class PrometheusExporter implements MetricExporter { request: IncomingMessage, response: ServerResponse ) => { - if (url.parse(request.url!).pathname === this._endpoint) { + if (request.url && new url.URL(request.url).pathname === this._endpoint) { this._exportMetrics(response); } else { this._notFound(response);