From 675765374c71dc464403cff4e3e7b55029fc4e57 Mon Sep 17 00:00:00 2001 From: naseemkullah Date: Mon, 25 Jan 2021 08:06:23 -0500 Subject: [PATCH] fix: error handle server listen promise Signed-off-by: naseemkullah --- .../src/PrometheusExporter.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts b/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts index 0c44c7356dd..697bc0139f4 100644 --- a/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts +++ b/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts @@ -36,7 +36,7 @@ export class PrometheusExporter implements MetricExporter { }; private readonly _logger: api.Logger; - private readonly _host: string; + private readonly _host?: string; private readonly _port: number; private readonly _endpoint: string; private readonly _server: Server; @@ -74,7 +74,7 @@ export class PrometheusExporter implements MetricExporter { ).replace(/^([^/])/, '/$1'); if (config.preventServerStart !== true) { - this.startServer().then(callback); + this.startServer().then(callback).catch(err => this._logger.error(err)); } else if (callback) { callback(); }