Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @opentelemetry/semantic-conventions #98

Closed
mayurkale22 opened this issue Jun 19, 2020 · 2 comments
Closed

Use @opentelemetry/semantic-conventions #98

mayurkale22 opened this issue Jun 19, 2020 · 2 comments
Labels
enhancement New feature or request good first issue up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@mayurkale22
Copy link
Member

@opentelemetry/semantic-conventions has been published in 0.9.0. Update all the relevant plugins to use this commonly defined enums.

Same as open-telemetry/opentelemetry-js#1160

/cc @markwolff
@mayurkale22 mayurkale22 added enhancement New feature or request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jun 19, 2020
@MarkSeufert
Copy link
Contributor

MarkSeufert commented Sep 14, 2020 •
edited
Loading

I believe this issue has already been partially complete within issues #167, #183, and #187. Looking at how these new issues used the new semantics would be a good starting point for modifying all the other relevant plugins.

@vmarchaud
Copy link
Member

I'll close this since all instrumentation use semantic conventions now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dyladan @vmarchaud @mayurkale22 @MarkSeufert