Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis instrumentation - support v4 #834

Closed
blumamir opened this issue Jan 14, 2022 · 5 comments · Fixed by #982
Closed

redis instrumentation - support v4 #834

blumamir opened this issue Jan 14, 2022 · 5 comments · Fixed by #982
Assignees
@blumamir
Labels
good first issue never-stale

Comments

@blumamir
Copy link
Member

Looks like the redis package released v4

Out instrumentation currently only supports v2 and v3

This issue is to add support to this instrumentation for the new v4.
This will also resolve this PR
@blumamir blumamir added good first issue up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jan 14, 2022
@blumamir blumamir mentioned this issue Jan 15, 2022
Closed
1 task
@YanivD YanivD mentioned this issue Mar 2, 2022
Merged
1 task
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Mar 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as completed Apr 4, 2022
@dyladan dyladan reopened this Apr 7, 2022
@dyladan dyladan added never-stale and removed stale labels Apr 7, 2022
@maxbol
Copy link

maxbol commented Apr 17, 2022

any progress on this?

@vmarchaud
Copy link
Member

@maxbol Its up for grab so i believe no one started to work on this

@blumamir blumamir self-assigned this Apr 26, 2022
@blumamir
Copy link
Member Author

I am working on adding support for v4.
Will be ready soon

@blumamir blumamir removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Apr 26, 2022
@blumamir blumamir mentioned this issue Apr 26, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blumamir blumamir

Labels
good first issue never-stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(instrumentation-redis): add support for redis@^4.0.0 blumamir/opentelemetry-js-contrib
4 participants
@maxbol @dyladan @vmarchaud @blumamir