Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename lerna's --include-filtered-dependencies option #817

Merged

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Jan 4, 2022

Which problem is this PR solving?

--include-filtered-dependencies option is deprecated:
lerna/lerna@f2c3a92

Short description of the changes

Rename --include-filtered-dependencies -> --include-dependencies.
Also substituting $(npm pkg get name) in the package.json of @opentelemetry/instrumentation-aws-sdk - GHA logs seem to tell us it's not properly working.

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #817 (a2dbe7d) into main (a2b71cf) will increase coverage by 0.17%.
The diff coverage is n/a.

❗ Current head a2dbe7d differs from pull request most recent head 8aba5e9. Consider uploading reports for the commit 8aba5e9 to get more accurate results

@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
+ Coverage   94.91%   95.08%   +0.17%     
==========================================
  Files          14      200     +186     
  Lines         708    13764   +13056     
  Branches      142     1312    +1170     
==========================================
+ Hits          672    13088   +12416     
- Misses         36      676     +640     
Impacted Files Coverage Δ
...or-aws/test/detectors/AwsBeanstalkDetector.test.ts 100.00% <0.00%> (ø)
...etry-instrumentation-router/src/instrumentation.ts 96.15% <0.00%> (ø)
...entelemetry-instrumentation-fastify/src/version.ts 100.00% <0.00%> (ø)
...strumentation-aws-lambda/test/lambda-test/async.js 100.00% <0.00%> (ø)
...strumentation-connect/test/instrumentation.test.ts 98.97% <0.00%> (ø)
...detector-aws/src/detectors/AwsBeanstalkDetector.ts 95.65% <0.00%> (ø)
...tension-autoinjection/test/instrumentation.test.ts 100.00% <0.00%> (ø)
...ce-detector-gcp/test/detectors/GcpDetector.test.ts 100.00% <0.00%> (ø)
...extension-autoinjection/src/contentScript/index.ts 0.00% <0.00%> (ø)
...emetry-id-generator-aws-xray/src/platform/index.ts 100.00% <0.00%> (ø)
... and 176 more

lerna.json Show resolved Hide resolved
@rauno56 rauno56 merged commit cf268e7 into open-telemetry:main Jan 4, 2022
@dyladan dyladan mentioned this pull request Jan 4, 2022
@rauno56 rauno56 deleted the fix/rename-include-filtered-deps branch January 5, 2022 09:52
This was referenced Feb 25, 2022
@chingor13 chingor13 mentioned this pull request Feb 28, 2022
@dyladan dyladan mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants