Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update koa plugin to specify route in span name #262

Closed
akshah123 opened this issue Nov 12, 2020 · 2 comments
Closed

Update koa plugin to specify route in span name #262

akshah123 opened this issue Nov 12, 2020 · 2 comments
Assignees

Comments

@akshah123
Copy link
Contributor

akshah123 commented Nov 12, 2020

Is your feature request related to a problem? Please describe.
Recently, plugin-http was updated to not have pathname in the span name: open-telemetry/opentelemetry-js#1466

It was done with expectation that other plugins like express would add parameterized route in the span name.

Unfortunately, koa plugin doesn't do this so upgrading to the latest opentelemetry version causes traces to be less useful.

Describe the solution you'd like
It would be great if koa plugin can update span name similar to how express does it here: #176

Describe alternatives you've considered
None.

@obecny obecny self-assigned this Nov 17, 2020
@obecny
Copy link
Member

obecny commented Nov 18, 2020

@akshah123
I’m trying to understand what do you mean by saying It would be great if koa plugin can update span name similar to how express does it here, because this is what I see in some knex / koa postgresql application

Screenshots

Can you please tell me what is wrong here ?

@akshah123
Copy link
Contributor Author

@obecny I didn't realize that route gets added as a separate span as well. Initially, HTTP Get span used to have path name as well. I think it should be fine to just have it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants