Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@opentelemetry/instrumentation-winston): Removing error details when @opentelemetry/winston-transport is not available #2301

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

hectorhdzg
Copy link
Member

Which problem is this PR solving?

Fixes #2244

Short description of the changes

Removed error details in diag.warn call

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.30%. Comparing base (dfb2dff) to head (5305e0b).
Report is 178 commits behind head on main.

Current head 5305e0b differs from pull request most recent head 7d281e0

Please upload reports for the commit 7d281e0 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2301      +/-   ##
==========================================
- Coverage   90.97%   90.30%   -0.68%     
==========================================
  Files         146      147       +1     
  Lines        7492     7263     -229     
  Branches     1502     1509       +7     
==========================================
- Hits         6816     6559     -257     
- Misses        676      704      +28     
Files Coverage Δ
...try-instrumentation-winston/src/instrumentation.ts 67.80% <ø> (+10.19%) ⬆️

... and 58 files with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module '@opentelemetry/winston-transport'
3 participants