-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry-instrumentation-pino not working with pino 9.0.0 #2155
Comments
I thought that might be the case then forget to check 🤦. Thanks for the clarification The only change in pino 9 is the project dropping support for node < 18. |
This was referenced Apr 29, 2024
Opened #2163 to add support for new pino version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of OpenTelemetry are you using?
"@opentelemetry/auto-instrumentations-node": "0.44.0"
"@opentelemetry/resources": "1.24.0"
"@opentelemetry/sdk-node": "0.51.0"
"@opentelemetry/semantic-conventions": "1.24.0"
What version of Node are you using?
20.12.0
What did you do?
Updated from pino 8.21.0 to 9.0.0
What did you expect to see?
otel properties in pino log output
What did you see instead?
no otel properties in pino log output
Additional context
I've been switching between the two versions and it logs correct in 8 but not 9, so it's only the version of pino that seems to be causing this.
Logging out the pino instance you can see that the otel mixin has not been added to log trace ids, etc:
pino 8.21.0
pino 9.0.0
The text was updated successfully, but these errors were encountered: