feat(fastify): add requestHook support #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luismiramirez
force-pushed
the
fastify-request-hook
branch
from
a6c063f
to
679c56b
Compare
The `requestHook` config option allows custom span handling per request layer.
luismiramirez
force-pushed
the
fastify-request-hook
branch
from
679c56b
to
2549d4c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
==========================================
+ Coverage 96.08% 96.09% +0.01%
==========================================
Files 14 19 +5
Lines 893 1127 +234
Branches 191 233 +42
==========================================
+ Hits 858 1083 +225
- Misses 35 44 +9
|
blumamir
reviewed
Oct 27, 2022
plugins/node/opentelemetry-instrumentation-fastify/src/types.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/src/types.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
2 tasks
- Add a test for when an exception is thrown from inside the hook - Export the types - Don't use Fastify core types so the package doesn't need to be a dependency - Rephrase docs to be clearer about when the request hook is executed - Remove sinon - Use proper component to log hook errors
blumamir
reviewed
Nov 3, 2022
plugins/node/opentelemetry-instrumentation-fastify/src/types.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
- Fix types in docs - Make FastifyRequestInfo an interface - Use SemanticAttributes enums instead of plain strings - Remove extra diag error call - Some lint fixes
luismiramirez
force-pushed
the
fastify-request-hook
branch
from
7be51f9
to
44b7c5f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requestHookconfig option allows custom span handling per request layer.Which problem is this PR solving?
requestHooksupport so users can add custom handling on spans.Short description of the changes
requestHookis implemented in web instrumentationsrequestHookuser-defined function is called any time_hookPreHandler()is executed