feat(koa): add requestHook support #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osherv
reviewed
Jul 27, 2022
Comment on lines
+35
to
+39
| export type KoaRequestInfo = { | ||
| context: KoaContext; | ||
| middlewareLayer: KoaMiddleware; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Thanks for noticing. This should be part of the requestHook. Fixing it.
There was a problem hiding this comment.
Fixed! The idea is to replicate the behaviour suggested here: #1091 (comment)
There was a problem hiding this comment.
Oh yea, i wasn't sure if that's what u meant to do.
Nice :)
luismiramirez
force-pushed
the
request-hook-koa
branch
from
11a8b6a
to
7ac4ed2
Compare
osherv
approved these changes
Jul 27, 2022
vmarchaud
approved these changes
Jul 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
==========================================
+ Coverage 96.07% 96.36% +0.29%
==========================================
Files 14 19 +5
Lines 892 1046 +154
Branches 191 220 +29
==========================================
+ Hits 857 1008 +151
- Misses 35 38 +3
|
The `requestHook` support allows custom span handling per middleware layer on requests.
luismiramirez
force-pushed
the
request-hook-koa
branch
from
7ac4ed2
to
013b46c
Compare
blumamir
approved these changes
Aug 10, 2022
| ); | ||
|
|
||
| const requestHook = sinon.spy((span: Span, info: KoaRequestInfo) => { | ||
| span.setAttribute('http.method', info.context.request.method); |
There was a problem hiding this comment.
better to use the enum SemanticAttributes.HTTP_METHOD
|
@luismiramirez friendly ping because the lint is failling |
|
@vmarchaud Linter issues addressed! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requestHooksupport allows custom span handling per middlewarelayer on requests.
Which problem is this PR solving?
requestHooksupport so users can add custom handling on spans per middleware layer on requests.Short description of the changes
requestHookis implemented in other instrumentationsrequestHookuser-defined function is called any time a patched middleware runs and if the function exists.Checklist
npm run test-all-versionsfor the edited package(s) on the latest commit if applicable.