Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid type imports of the aws-sdk package in the built assets #1066

Merged
merged 6 commits into from
Sep 13, 2022

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Jun 22, 2022

Which problem is this PR solving?

This is a subset of #1017 that touches aws-sdk types because of the legal discussion holding merging those back.

Short description of the changes

See #1017

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1066 (cba5b69) into main (954f29c) will increase coverage by 0.53%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
+ Coverage   96.07%   96.61%   +0.53%     
==========================================
  Files          14       25      +11     
  Lines         892     1446     +554     
  Branches      191      308     +117     
==========================================
+ Hits          857     1397     +540     
- Misses         35       49      +14     
Impacted Files Coverage Δ
...entation-aws-sdk/src/services/MessageAttributes.ts 91.89% <ø> (ø)
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 97.44% <100.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.29% <100.00%> (ø)
...etry-instrumentation-aws-sdk/src/services/index.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 100.00% <0.00%> (ø)
...ntation-aws-sdk/src/services/ServicesExtensions.ts 100.00% <0.00%> (ø)
...try-instrumentation-aws-sdk/src/services/lambda.ts 97.77% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/enums.ts 100.00% <0.00%> (ø)
... and 4 more

@dyladan
Copy link
Member

dyladan commented Aug 9, 2022

Just wanted to let you know there is a service desk ticket for this CNCFSD-1369

@dyladan
Copy link
Member

dyladan commented Sep 8, 2022

https://github.com/cncf/foundation/blob/main/copyright-notices.md#what-about-third-party-code

looks like if we don't modify their types we would just preserve their copyright notice and not add our own

@rauno56
Copy link
Member Author

rauno56 commented Sep 9, 2022

Added 3rd party copyright notice because we do change them slightly.

@rauno56 rauno56 merged commit 457be50 into open-telemetry:main Sep 13, 2022
@rauno56 rauno56 deleted the fix/build-types-2 branch September 13, 2022 08:00
@dyladan dyladan mentioned this pull request Sep 13, 2022
@dyladan dyladan mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants