-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid type imports of the aws-sdk package in the built assets #1066
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
+ Coverage 96.07% 96.61% +0.53%
==========================================
Files 14 25 +11
Lines 892 1446 +554
Branches 191 308 +117
==========================================
+ Hits 857 1397 +540
- Misses 35 49 +14
|
Just wanted to let you know there is a service desk ticket for this CNCFSD-1369 |
https://github.com/cncf/foundation/blob/main/copyright-notices.md#what-about-third-party-code looks like if we don't modify their types we would just preserve their copyright notice and not add our own |
Added 3rd party copyright notice because we do change them slightly. |
Which problem is this PR solving?
This is a subset of #1017 that touches
aws-sdk
types because of the legal discussion holding merging those back.Short description of the changes
See #1017
Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.