Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest proto version needed in 0.14.0 release #2021

Closed
gcacace opened this issue Nov 5, 2020 · 9 comments
Closed

Latest proto version needed in 0.14.0 release #2021

gcacace opened this issue Nov 5, 2020 · 9 comments
Labels
Feature Request Suggest an idea for this project

Comments

@gcacace
Copy link

gcacace commented Nov 5, 2020

Is your feature request related to a problem? Please describe.
The change in 711efc3 is needed for our use case and we would like to see this shipped in the next version of this package

Describe the solution you'd like
Bump-up to 0.14.0 and release to Maven Central

Describe alternatives you've considered
None. For our use case we need the new version in Maven Central

Additional context
This is required for a CloudWatch use case

@gcacace gcacace added the Feature Request Suggest an idea for this project label Nov 5, 2020
@jkwatson
Copy link
Contributor

jkwatson commented Nov 5, 2020

Hi @gcacace . We have just released 0.10.0. thanks!

@jkwatson jkwatson closed this as completed Nov 5, 2020
@gcacace
Copy link
Author

gcacace commented Nov 5, 2020

But the new version is not in Maven Central: https://mvnrepository.com/artifact/io.opentelemetry/opentelemetry-proto

@bogdandrutu
Copy link
Member

And does not have the proto change you need :)

@gcacace gcacace changed the title Release 0.10.0 needed Latest proto version needed in 0.10.1 release Nov 5, 2020
@gcacace
Copy link
Author

gcacace commented Nov 5, 2020

Can we then reopen this issue please?

@bogdandrutu bogdandrutu reopened this Nov 5, 2020
@jkwatson
Copy link
Contributor

jkwatson commented Nov 5, 2020

We need to wait for a protobuf release before we will depend on it in the project. Otherwise we risk releases with non-released versions of the protobuf that won't be supported by anything.

@shalk
Copy link
Contributor

shalk commented Dec 18, 2020

the commit open-telemetry/opentelemetry-proto@8ab21e9 which release in proto v0.6.0 have released in 0.12.0 or later. (see proto/build.gradle).

@gcacace gcacace changed the title Latest proto version needed in 0.10.1 release Latest proto version needed in 0.14.0 release Jan 11, 2021
@gcacace
Copy link
Author

gcacace commented Jan 11, 2021

@bogdandrutu made the change to consume the latest proto package (see: 711efc3). Can someone release the new version of this Java package in Maven Central please?

@jkwatson
Copy link
Contributor

@bogdandrutu made the change to consume the latest proto package (see: 711efc3). Can someone release the new version of this Java package in Maven Central please?

This release has been incorporated into the main branch of the java project. It is currently available in snapshot builds. It'll get released on the normal release schedule, within a week or so.

@gcacace I will repeat what I've said before: if you have urgent dependencies on having java protobuf bindings in a more timely manner than what happens to be included in the java SDK, you should maintain your own build/publishing pipeline to manage this, and not rely on the larger java project artifacts.

@jkwatson
Copy link
Contributor

jkwatson commented Mar 5, 2021

closing this

@jkwatson jkwatson closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

4 participants