From b3881bf90444df25282ce6226d1ba45abf0fef63 Mon Sep 17 00:00:00 2001 From: jack-berg Date: Fri, 25 Feb 2022 11:23:26 -0600 Subject: [PATCH] PR feedback --- .../sdk/metrics/SdkObservableInstrument.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkObservableInstrument.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkObservableInstrument.java index 216e199ba1d..a5f4f523893 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkObservableInstrument.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkObservableInstrument.java @@ -44,11 +44,11 @@ class SdkObservableInstrument @Override public void close() { - if (removed.compareAndSet(false, true)) { - storages.forEach(storage -> storage.removeCallback(callback)); + if (!removed.compareAndSet(false, true)) { + throttlingLogger.log( + Level.WARNING, "Instrument " + instrumentName + " has called close() multiple times."); return; } - throttlingLogger.log( - Level.WARNING, "Instrument " + instrumentName + " has called close() multiple times."); + storages.forEach(storage -> storage.removeCallback(callback)); } }