-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename all newBuilder()
method to builder()
#4392
Labels
enhancement
New feature or request
Comments
Closed by #4407 |
Unfortunately it's not done yet; the |
I found that there are many lines of code in this method that are not formatted, so I missed it when I modified it last time. I will resubmit a PR to fix it. |
This was referenced Oct 22, 2021
Closed by #4475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I've noticed that the API & SDK uses the
builder()
name for the method that returns a new object builder. E.g.Attributes#builder()
,Baggage#builder()
,OpenTelemetrySdk#builder()
. We should strive for consistency and do the same thing in all public APIs:Instrumenter#newBuilder()
->Instrumenter#builder()
...Tracing#newBuilder()
->...Tracing#builder()
The text was updated successfully, but these errors were encountered: