Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all newBuilder() method to builder() #4392

Closed
mateuszrzeszutek opened this issue Oct 15, 2021 · 4 comments
Closed

Rename all newBuilder() method to builder() #4392

mateuszrzeszutek opened this issue Oct 15, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@mateuszrzeszutek
Copy link
Member

Is your feature request related to a problem? Please describe.
I've noticed that the API & SDK uses the builder() name for the method that returns a new object builder. E.g. Attributes#builder(), Baggage#builder(), OpenTelemetrySdk#builder(). We should strive for consistency and do the same thing in all public APIs:

  • Instrumenter#newBuilder() -> Instrumenter#builder()
  • ...Tracing#newBuilder() -> ...Tracing#builder()
@mateuszrzeszutek mateuszrzeszutek added the enhancement New feature or request label Oct 15, 2021
@mateuszrzeszutek mateuszrzeszutek linked a pull request Oct 18, 2021 that will close this issue
@iNikem
Copy link
Contributor

iNikem commented Oct 20, 2021

Closed by #4407

@iNikem iNikem closed this as completed Oct 20, 2021
@mateuszrzeszutek
Copy link
Member Author

Unfortunately it's not done yet; the Instrumenter#newBuilder() method wasn't renamed

@MartinDai
Copy link
Contributor

Unfortunately it's not done yet; the Instrumenter#newBuilder() method wasn't renamed

I found that there are many lines of code in this method that are not formatted, so I missed it when I modified it last time. I will resubmit a PR to fix it.

@mateuszrzeszutek
Copy link
Member Author

Closed by #4475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants