Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ExperimentalConfig to javaagent-instrumentation-api #4238

Closed
mateuszrzeszutek opened this issue Sep 29, 2021 · 1 comment
Closed

Move ExperimentalConfig to javaagent-instrumentation-api #4238

mateuszrzeszutek opened this issue Sep 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@mateuszrzeszutek
Copy link
Member

The ExperimentalConfig contains config properties that are not supposed to be used in library instrumentations; they're meant to be consumed by the javaagent ones. We should move the class to the javaagent-instrumentation-api module and hide it from the library instrumentations.

(I'm starting to wonder if we should do the same thing for Config too, since it's not meant to be used by library instrumentations)

Additional context
Inspired by #4235 and https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/4237/files#diff-4801c9b77f266ab53ec0831d7b40ec3ab819faa1abfc685ac9897f460bd3292a
@mateuszrzeszutek mateuszrzeszutek added the enhancement New feature or request label Sep 29, 2021
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Sep 30, 2021
Closed
@mateuszrzeszutek
Copy link
Member Author

Closing this - we've decided to keep Config and related classes in instrumentation-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@mateuszrzeszutek